Handle error when joining room in the external signaling server #3804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"roomCollection" is a leftover from Talk < 8. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Joining a room in the external signaling server can fail (for example, if the Nextcloud server took too long to send a response and joining timed out). When that happens an error is returned, but the error was ignored. Now, when joining a room in the external signaling server fails it is tried again and again until the room is joined. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
feature: signaling 📶
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
4 tasks
nickvergessen
modified the milestones:
v10.0.0-beta.1,
💙 Next Minor (19),
💚 Next Major (20)
4 tasks
nickvergessen
modified the milestones:
💚 Next Major (20),
💛 Next Minor (20),
💚 Next Major (21)
nickvergessen
modified the milestones:
11.0.0-alpha.1,
💚 Next Major (21),
11.0.0-alpha.2,
💚 Next Alpha (21)
Member
|
Master is 22 now |
Member
|
I will close the PR for now (as there was no active development since 6 months). Anyone can pick it up whenever they want and reopen the PR. |
nickvergessen
deleted the
handle-error-when-joining-room-in-the-external-signaling-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test (scenario 1)
if (rand(0, 9) < 7) { sleep(11); }before the ping inSignalingController(11 or whatever value you have set as the timeout in the external signaling server + 1)Join room XXXis shown followed byJoined, which means that joining in the external signaling server did not wait and succeeded)Join room XXXis shown but it is not followed byJoined, which means that joining in the external signaling server is taking longer)Result with this pull request
Joinedis eventually shown with an error, but joining is automatically retried until it succeeds. The call view is not shown until the conversation is joined, and when that happens it connects to user A.Result without this pull request
Joinedis eventually shown with an error. The call view is immediately shown, but it never connects to user A.How to test (scenario 2) - WIP
if (rand(0, 9) < 3) { sleep(8); }before the ping inSignalingController(8 or whatever value you have set as the timeout in the external signaling server - 2)Join room XXXis shown but it is not followed byJoined, which means that joining in the external signaling server is taking longer)Join room XXXis shown followed byJoined, which means that joining in the external signaling server did not wait and succeeded)Result with this pull request
Joinedis eventually shown for the previous conversation, but the latest conversation is automatically joined again. If a call is started it will connect to the other user.Result without this pull request
Joinedis eventually shown for the previous conversation. If a call is started it will never connect to the other user.