Add abilitiy to select localvideo #3814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoambrosini
changed the title
marcoambrosini
force-pushed
the
feature/3517/add-ability-to-select-yourself-in-callview
branch
2 times, most recently
from
0e331ce to
8d9ad21
Compare
nickvergessen
added
3. to review
enhancement
feature: call 📹
Member
|
I can not select my own video nor mute myself or disable the video anymore in the promoted view. |
Member
Author
|
Fixed @nickvergessen |
Member
|
Now the only thing missing is being able to select your own video in promoted view |
Member
Author
|
Also fixed :) |
Member
|
You can click on your own field when you only have an avatar and it turns the screen black? |
marcoambrosini
force-pushed
the
feature/3517/add-ability-to-select-yourself-in-callview
branch
3 times, most recently
from
3f451de to
e6457cd
Compare
Member
|
It seems that this was mostly merged in #3884, but the last commit is different. |
marcoambrosini
force-pushed
the
feature/3517/add-ability-to-select-yourself-in-callview
branch
from
e6457cd to
26ac939
Compare
Signed-off-by: Marco Ambrosini <[email protected]>
marcoambrosini
force-pushed
the
feature/3517/add-ability-to-select-yourself-in-callview
branch
from
26ac939 to
ab7c677
Compare
Signed-off-by: Marco Ambrosini <[email protected]>
nickvergessen
approved these changes
Aug 26, 2020
nickvergessen
deleted the
feature/3517/add-ability-to-select-yourself-in-callview
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marco Ambrosini [email protected]