Skip to content

Add unread message marker in the chat view #3825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 17 commits into from
Mar 9, 2021
Merged

Add unread message marker in the chat view #3825

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
abe329c
Add unread message marker in the chat view
nickvergessen Jun 18, 2020
c4e739c
Update last read message marker on scroll
PVince81 Feb 10, 2021
6929de8
Don't mark conversation as read any more on click
PVince81 Feb 23, 2021
f24ac54
Properly clear when focussed and sticky
PVince81 Feb 24, 2021
4d5ad40
Read marker tweaks
PVince81 Feb 24, 2021
3c6d5bc
Scroll to unread when reopening sidebar with chat
PVince81 Feb 24, 2021
b99adb6
Tweak read marker behavior
PVince81 Mar 1, 2021
31b3c3e
Read marker is now a long bar
PVince81 Mar 1, 2021
3dbd551
Use DOM attributes to access message/seen information
PVince81 Mar 1, 2021
30285b0
Fix immediate update of read marker
PVince81 Mar 1, 2021
9374c25
New menu item mark conversation as read
PVince81 Mar 2, 2021
22eb262
New menu item mark message as unread
PVince81 Mar 2, 2021
f8ca906
Move unread messages marker out of the hover element
PVince81 Mar 4, 2021
0298bf5
Decouple visible unread marker from its actual position
PVince81 Mar 4, 2021
579fbdc
Remove delay for unread marker on focus
PVince81 Mar 4, 2021
7d4d6fb
Mark as unread now applied to previous message id
PVince81 Mar 4, 2021
c26d5e3
Update read marker UI when posting + tweaks
PVince81 Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Read marker tweaks 
Adjust design a bit of the marker.

Debounce read marker processor on focus to delay it a bit.

Signed-off-by: Vincent Petry <[email protected]>
  • Loading branch information
@PVince81
PVince81 committed Mar 8, 2021
commit 4d5ad40f26b1c8749c4bcd3350724f6b8d13d40a
2 changes: 1 addition & 1 deletion src/components/MessagesList/MessagesGroup/Message/Message.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ the main body of the message as well as a quote.
<div v-if="isLastReadMessage"
v-observe-visibility="lastReadMessageVisibilityChanged">
<div v-if="!isLastMessage" class="new-message-marker">
<span>{{ t('spreed', 'New messages') }}</span>
<span>----- {{ t('spreed', 'Unread messages') }} -----</span>
</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/MessagesList/MessagesList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,7 +909,7 @@ export default {
},

onWindowFocus() {
this.updateReadMarkerAfterScroll()
this.debounceUpdateReadMarkerAfterScroll()
},
},
}
Expand Down