Fix speaker promotion with newer Janus versions #3940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Janus is used even if it is possible to open several data channels with different labels and send data on them all the messages are received in the first data channel opened. Although currently several data channels are opened in Talk in practice only the "status" data channel is used (and messages received in data channels with a different label are ignored). This is also the first data channel opened when Janus is used, so until now everything happened to work (with Janus 0.4.3). However, with newer Janus versions the data channel messages are received instead on a data channel opened by Janus, which is named "JanusDataChannel". It is not possible to change that behaviour on Janus except by patching it, so for broader compatibility the messages received in "JanusDataChannel" are treated like messages received in the "status" data channel (this was partially done already; this commit finishes the change). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
feature: WebRTC 🚡
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
nickvergessen
approved these changes
Jul 27, 2020
nickvergessen
deleted the
fix-speaker-promotion-with-newer-janus-versions
branch
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
This was referenced Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (in the WebUI, but changes in the mobile apps are needed) #3937
When Janus is used even if it is possible to open several data channels with different labels and send data on them all the messages are received in the first data channel opened.
Although currently several data channels are opened in Talk in practice only the "status" data channel is used (and messages received in data channels with a different label are ignored). This is also the first data channel opened when Janus is used, so until now everything happened to work (with Janus 0.4.3).
However, with newer Janus versions the data channel messages are received instead on a data channel opened by Janus, which is named "JanusDataChannel". It is not possible to change that behaviour on Janus except by patching it, so for broader compatibility the messages received in "JanusDataChannel" are treated like messages received in the "status" data channel (this was partially done already; this commit finishes the change).