Skip to content

Handle referenceId for system messages e.g. when uploading a file #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Jul 28, 2020
Merged

Handle referenceId for system messages e.g. when uploading a file #3948

nickvergessen merged 1 commit into from
Jul 28, 2020

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 27, 2020

Signed-off-by: Joas Schilling [email protected]

@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Jul 27, 2020
@nickvergessen nickvergessen added this to the 💚 Next Major (20) milestone Jul 27, 2020
@nickvergessen nickvergessen mentioned this pull request Jul 27, 2020
Merged
@nickvergessen nickvergessen force-pushed the bugfix/noid/handle-reference-id-for-system-messages branch from 268563d to bbd1b90 Compare July 28, 2020 07:44
@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 28, 2020

Failing unit tests are fixed with nextcloud/server#22027

danxuliu
danxuliu approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

One little thing that I have noticed: if you upload a large file and send new messages while the file is being uploaded the file will appear after those messages. Honestly I do not know if a user would expect the file to appear in the message list where it started to upload or where it ended to upload.

Also I guess that to change the behaviour some more hacks will be needed to explicitly assign a date to system messages or something like that, so I do not know if it is worth the trouble. In any case, something for a follow up pull request I would say.

@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 28, 2020

One little thing that I have noticed: if you upload a large file and send new messages while the file is being uploaded the file will appear after those messages. Honestly I do not know if a user would expect the file to appear in the message list where it started to upload or where it ended to upload.

Hmm yeah well it's the same for when your sending a message takes longer the order could be different if you dont wait for the finishing.

@nickvergessen nickvergessen merged commit 9f0c94e into master Jul 28, 2020
@nickvergessen nickvergessen deleted the bugfix/noid/handle-reference-id-for-system-messages branch July 28, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@danxuliu danxuliu danxuliu approved these changes

Assignees

No one assigned

Labels

4. to release bug feature: chat 💬 Chat and system messages feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings

Projects

None yet

Milestone

v10.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @marcoambrosini @danxuliu