Keyboard navigation for conversation search #3955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
force-pushed
the
bugfix/noid/preselect-first-conversation-on-search
branch
from
0e7fe13 to
00ccf7c
Compare
Signed-off-by: Joas Schilling <[email protected]>
…ta is handled in one place Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/preselect-first-conversation-on-search
branch
2 times, most recently
from
1ebbf8e to
6573065
Compare
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/preselect-first-conversation-on-search
branch
from
6573065 to
5bdb886
Compare
Member
Author
|
Now works based on the unified search focus functions. We have the mixin here locally until it's merged in the vue lib. |
nickvergessen
changed the title
Member
Author
|
Did you forget to build? it works very fine here. |
4 tasks
Member
|
let me retry :) |
marcoambrosini
approved these changes
Sep 4, 2020
marcoambrosini
deleted the
bugfix/noid/preselect-first-conversation-on-search
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to manage a "fake hover" state which I guess should then also be keyboard navigateable.
But at least I got enter to work 😬
Fix #2816