Conversations in Unified Search #3960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
2. developing
enhancement
feature: api 🛠️
nickvergessen
force-pushed
the
feature/3493/conversations-in-unified-search
branch
from
0302f40 to
8cb70f3
Compare
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
feature/3493/conversations-in-unified-search
branch
from
8cb70f3 to
f89c938
Compare
skjnldsv
reviewed
Aug 3, 2020
| @@ -0,0 +1,23 @@ | |||
| .unified-search { | |||
| .conversation-icon { | |||
| background-color: var(--color-background-darker); | |||
Member
There was a problem hiding this comment.
Right, haven't thought of this 🤔
Ideally you shouldn't have to apply custom styling to a properly designed api.
(nonetheless what you did is very clean!)
@georgehrke @juliushaertl thoughts?
Member
Author
There was a problem hiding this comment.
Well this is how the talk icons work. we use "32px round background + 22px icon on top" as our "icon"
jancborchardt
approved these changes
Aug 3, 2020
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Tested and works well! (except the separate stuff mentioned in chat about page refresh inside Talk, and the now transitional state of now two search fields.)
skjnldsv
approved these changes
Aug 3, 2020
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Other than my undecided mind on how to better tackle this, it's clean and looks great! 💯
georgehrke
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3493
Last message as subline? Or participants?=> None for now due to performance