Skip to content

[stable18] Fix Internet Explorer 11 not loading because Element.append() does no… #3983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Aug 3, 2020
Merged

[stable18] Fix Internet Explorer 11 not loading because Element.append() does no… #3983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/FilesSidebarCallViewApp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ export default {
}
}

header.append(this.$el)
header.appendChild(this.$el)
},

/**
Expand All @@ -274,7 +274,7 @@ export default {

const headerAction = document.querySelector('.app-sidebar-header__action')
if (headerAction) {
headerAction.append(this.$el)
headerAction.appendChild(this.$el)
}
},
},
Expand Down
2 changes: 1 addition & 1 deletion src/collections.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ import RoomSelector from './views/RoomSelector'
const container = document.createElement('div')
container.id = 'spreed-room-select'
const body = document.getElementById('body-user')
body.append(container)
body.appendChild(container)
const ComponentVM = new Vue({
render: h => h(RoomSelector),
})
Expand Down
14 changes: 7 additions & 7 deletions src/mainPublicShareAuthSidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ function wrapBody() {
const bodyWrapperElement = document.createElement('div')

while (bodyElement.childNodes.length) {
bodyWrapperElement.append(bodyElement.childNodes[0])
bodyWrapperElement.appendChild(bodyElement.childNodes[0])
}

while (bodyElement.classList.length) {
Expand All @@ -76,24 +76,24 @@ function wrapBody() {
bodyWrapperElement.setAttribute('id', bodyElement.getAttribute('id'))
bodyElement.removeAttribute('id')

bodyElement.append(bodyWrapperElement)
bodyElement.appendChild(bodyWrapperElement)
}

function adjustLayout() {
const contentElement = document.createElement('div')
contentElement.setAttribute('id', 'content')
document.querySelector('body').append(contentElement)
document.querySelector('body').appendChild(contentElement)

contentElement.append(document.querySelector('.wrapper'))
contentElement.append(document.querySelector('footer'))
contentElement.appendChild(document.querySelector('.wrapper'))
contentElement.appendChild(document.querySelector('footer'))

const requestPasswordElement = document.createElement('div')
requestPasswordElement.setAttribute('id', 'request-password')
document.querySelector('main').append(requestPasswordElement)
document.querySelector('main').appendChild(requestPasswordElement)

const talkSidebarElement = document.createElement('div')
talkSidebarElement.setAttribute('id', 'talk-sidebar')
document.querySelector('body').append(talkSidebarElement)
document.querySelector('body').appendChild(talkSidebarElement)

wrapBody()

Expand Down
8 changes: 4 additions & 4 deletions src/mainPublicShareSidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@ Vue.use(Vuex)
Vue.use(VueShortKey, { prevent: ['input', 'textarea', 'div'] })

function adjustLayout() {
document.querySelector('#app-content').append(document.querySelector('footer'))
document.querySelector('#app-content').appendChild(document.querySelector('footer'))

const talkSidebarElement = document.createElement('div')
talkSidebarElement.setAttribute('id', 'talk-sidebar')
document.querySelector('#content').append(talkSidebarElement)
document.querySelector('#content').appendChild(talkSidebarElement)
}

adjustLayout()
Expand Down Expand Up @@ -88,10 +88,10 @@ function addTalkSidebarTrigger() {
if (!document.querySelector('.header-right')) {
const headerRightElement = document.createElement('div')
headerRightElement.setAttribute('class', 'header-right')
document.querySelector('#header').append(headerRightElement)
document.querySelector('#header').appendChild(headerRightElement)
}

document.querySelector('.header-right').append(talkSidebarTriggerElement)
document.querySelector('.header-right').appendChild(talkSidebarTriggerElement)
}

addTalkSidebarTrigger()
Expand Down