Skip to content

💬 Status adaption for Nextcloud 20 #3993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 11 commits into from
Aug 5, 2020
Merged

💬 Status adaption for Nextcloud 20 #3993

nickvergessen merged 11 commits into from
Aug 5, 2020

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 5, 2020 •
edited
Loading

  • Add away/dnd state on mentions
  • Add away/dnd state on the participant list
  • Show status icon as overlay on avatars? => Follow up after nextcloud-vue support

Mentions

  • Status shown when away or dnd

Participant list

  • Status shown when away or dnd
  • People with status sorted to the end of their section (moderator, online, user status)

Bildschirmfoto von 2020-08-05 17-10-03

@nickvergessen nickvergessen added 2. developing enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client labels Aug 5, 2020
@nickvergessen nickvergessen added this to the 💚 Next Major (20) milestone Aug 5, 2020
@nickvergessen

This comment has been minimized.

Sign in to view
@nickvergessen

This comment has been minimized.

Sign in to view
@nickvergessen nickvergessen marked this pull request as ready for review August 5, 2020 12:57
@jancborchardt

This comment has been minimized.

Sign in to view
@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 5, 2020

Got some help, so it's now on a new line, but it should probably be trimmed in case the user has bad intentions
Bildschirmfoto von 2020-08-05 15-29-06

@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 5, 2020

But we can do that as a follow up

jancborchardt
jancborchardt reviewed Aug 5, 2020
View reviewed changes
@nickvergessen
Allow to get the status with mentions
e8613ff 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Show the status when mentioning people
47d2098 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Allow to get the status for the participant list
8f69f7c 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Show the status in the participant list
913583c 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Sort users down which are away + dnd
e2c5d7d 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Move status to a second line
bd4c78e 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Fix status styling on active element on mentions
7f3ac0d 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Fix paddings in the sidebar
af77da3 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Fix offline usernames
edf066b 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Add docs about status
ab2d012 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Fix unit tests
2c3c780 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen merged commit afeb321 into master Aug 5, 2020
@nickvergessen nickvergessen deleted the feature/noid/status branch August 5, 2020 21:06
@nickvergessen nickvergessen mentioned this pull request Aug 27, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt left review comments

@skjnldsv skjnldsv skjnldsv approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@georgehrke georgehrke Awaiting requested review from georgehrke

Assignees

No one assigned

Labels

4. to release enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v10.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen @jancborchardt @skjnldsv @marcoambrosini