new DB table to store bridge configs

Signed-off-by: Julien Veyssier <[email protected]>

lib/BridgeManager.php

@@ -25,6 +25,7 @@
 
 use OCP\IConfig;
 use OCP\IDBConnection;
+use OCP\DB\QueryBuilder\IQueryBuilder;
 use OCP\IL10N;
 use OCP\IUserManager;
 use OCP\Files\IAppData;
@@ -81,10 +82,7 @@ public function __construct(IDBConnection $db,
 	 * @return array decoded json bridge information
 	 */
 	public function getBridgeOfRoom(string $token): array {
-		$defaultParts = '{"enabled":false,"pid":0,"parts":[]}';
-		$bridgeJSON = $this->config->getAppValue('spreed', 'bridge_' . $token, $defaultParts);
-		$bridge = json_decode($bridgeJSON, true);
-		return $bridge;
+		return $this->getBridgeFromDb($token);
 	}
 
 	/**
@@ -111,8 +109,7 @@ public function editBridgeOfRoom(string $token, bool $enabled, array $parts = []
 		$newBridge['pid'] = $pid;
 
 		// save config
-		$newBridgeJSON = json_encode($newBridge);
-		$this->config->setAppValue('spreed', 'bridge_' . $token, $newBridgeJSON);
+		$this->saveBridgeToDb($token, $newBridge);
 
 		return true;
 	}
@@ -157,8 +154,7 @@ public function checkBridge(string $token) {
 		if ($pid !== $bridge['pid']) {
 			// save the new PID if necessary
 			$bridge['pid'] = $pid;
-			$bridgeJSON = json_encode($bridge);
-			$this->config->setAppValue('spreed', 'bridge_' . $token, $bridgeJSON);
+			$this->saveBridgeToDb($token, $bridge);
 		}
 	}
 
@@ -557,4 +553,66 @@ private function isRunning(int $pid): bool {
 		}
 		return false;
 	}
+
+	private function getBridgeFromDb(string $token): array {
+		$room = $this->manager->getRoomByToken($token);
+		$roomId = $room->getId();
+
+		$qb = $this->db->getQueryBuilder();
+		$qb->select('json_values')
+			->from('talk_bridges', 'b')
+			->where(
+				$qb->expr()->eq('room_id', $qb->createNamedParameter($roomId, IQueryBuilder::PARAM_INT))
+			);
+		$req = $qb->execute();
+		$jsonValues = '{"enabled":false,"pid":0,"parts":[]}';
+		while ($row = $req->fetch()) {
+			$jsonValues = $row['json_values'];
+			break;
+		}
+		$req->closeCursor();
+		$qb = $qb->resetQueryParts();
+
+		return json_decode($jsonValues, true);
+	}
+
+	private function saveBridgeToDb(string $token, array $bridge) {
+		$room = $this->manager->getRoomByToken($token);
+		$roomId = $room->getId();
+		$jsonValues = json_encode($bridge);
+
+		$qb = $this->db->getQueryBuilder();
+
+		$exists = false;
+		$qb->select('json_values')
+			->from('talk_bridges', 'b')
+			->where(
+				$qb->expr()->eq('room_id', $qb->createNamedParameter($roomId, IQueryBuilder::PARAM_INT))
+			);
+		$req = $qb->execute();
+		while ($row = $req->fetch()) {
+			$exists = true;
+			break;
+		}
+		$req->closeCursor();
+		$qb = $qb->resetQueryParts();
+
+		if ($exists) {
+			$qb->update('talk_bridges');
+			$qb->set('json_values', $qb->createNamedParameter($jsonValues, IQueryBuilder::PARAM_STR));
+			$qb->where(
+				$qb->expr()->eq('room_id', $qb->createNamedParameter($roomId, IQueryBuilder::PARAM_INT))
+			);
+			$req = $qb->execute();
+			$qb = $qb->resetQueryParts();
+		} else {
+			$qb->insert('talk_bridges')
+				->values([
+					'room_id' => $qb->createNamedParameter($roomId, IQueryBuilder::PARAM_INT),
+					'json_values' => $qb->createNamedParameter($jsonValues, IQueryBuilder::PARAM_STR),
+				]);
+			$req = $qb->execute();
+			$qb = $qb->resetQueryParts();
+		}
+	}
 }

lib/Migration/Version10000Date20200819121721.php

@@ -0,0 +1,68 @@
+<?php
+
+declare(strict_types=1);
+/**
+ * @copyright Copyright (c) 2020, Julien Veyssier <[email protected]>
+ *
+ * @author Julien Veyssier <[email protected]>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace OCA\Talk\Migration;
+
+use Closure;
+use Doctrine\DBAL\Types\Type;
+use OCP\DB\ISchemaWrapper;
+use OCP\Migration\IOutput;
+use OCP\Migration\SimpleMigrationStep;
+
+class Version10000Date20200819121721 extends SimpleMigrationStep {
+	/**
+	 * @param IOutput $output
+	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+	 * @param array $options
+	 * @return null|ISchemaWrapper
+	 */
+	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
+		/** @var ISchemaWrapper $schema */
+		$schema = $schemaClosure();
+
+		if (!$schema->hasTable('talk_bridges')) {
+			$table = $schema->createTable('talk_bridges');
+			$table->addColumn('id', Type::INTEGER, [
+				'autoincrement' => true,
+				'notnull' => true,
+				'length' => 11,
+			]);
+			$table->addColumn('room_id', Type::INTEGER, [
+				'notnull' => true,
+				'length' => 11,
+				'unsigned' => true,
+				'default' => 0,
+			]);
+			$table->addColumn('json_values', Type::STRING, [
+				'notnull' => true,
+				'length' => 10000,
+				'default' => '{}',
+			]);
+			$table->addIndex(['room_id'], 'tbr_room_id');
+		}
+
+		return $schema;
+	}
+}