Multiple fixes to the conversation selector for projects #4024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
bug
feature: integration 📦
juliusknorr
approved these changes
Aug 19, 2020
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Looks nice 👍
Though I only reviewed 36823e7 since the others seem unrelated 😉
Member
|
@nickvergessen I guess this needs a rebase to only contain the relevant commit |
- Conversations are not ordered as in the app navigation - Conversation icons are not as "expected" - Adjust selection style to current state of the art - Better styling of the headline Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/2314/project-fixes
branch
from
36823e7 to
9e2ecfb
Compare
Member
Author
|
Right, I based on #4023 instead of master... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2314