Remove unneeded check to enable MediaDevicesPreview when not in calls #4039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that selecting media devices is supported during calls too it is possible to relax the required property and enable the preview by default. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Now that selecting media devices is supported during calls too it is no longer needed to enable it only when not in calls (and besides that the preview was always enabled anyway due to a misuse of the mixin). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
nickvergessen
approved these changes
Aug 24, 2020
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Can't feel any difference ¯\_(ツ)_/¯
nickvergessen
deleted the
remove-unneeded-check-to-enable-mediadevicespreview-only-when-not-in-calls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4023 and #4032
This should have been done in #4023 after rebasing on #4032, but was probably missed because the preview was already enabled during calls. Actually, it was always enabled. And it was always enabled because when the preview was moved to the SettingsDialog the mixin always returned "not in call" due to being used in a component without token and participant properties.