[stable19] Prevent infinite loop in datachannel open re-transmission #4069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As there could be two data channels with the same name (created by the remote and local side) and they will be connected at different time, it is possible to get an onopen event while the other connection is still in connecting state. When the above situation happens, pendingMessages cannot be resent because the check is on the remote-to-local connection, which is still in "connecting" state, while the onopen is called for local-to-remote. At this moment the sendDirectly function will queue the message again and the loop will try to re-transmit the message again on the next iteration where it will be queue again, and so on. To prevent this infinite loop, a copy of the pendingMessages queue is created and resend happens on this "new" list. This way in case the channel is already opened the transmission will happen, and in case the channel is not yet opened it will be re-queued for the next onopen when the other connection is established. Signed-off-by: Vladislav Hristov <[email protected]>
backportbot-nextcloud
bot
added
bug
feature: WebRTC 🚡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #3882