Ignore "forceMute" message if already muted #4076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable19 |
nickvergessen
modified the milestones:
v10.0.0-beta.1,
💙 Next Minor (19),
💚 Next Major (20)
4 tasks
Before the UI only allowed to send the "forceMute" message to participants that were not muted. Now that moderators can mute all the other participants at once the message may be received by participants that are already muted, so it needs to be ignored in that case. Otherwise the user would see a "You have been muted by a moderator" notification even if already muted. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
ignore-forcemute-message-if-already-muted
branch
from
d2ff4f8 to
82ba579
Compare
danxuliu
added
3. to review
bug
feature: call 📹
nickvergessen
approved these changes
Sep 16, 2020
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Does what it says, although it might also be a good idea to tell people that a moderator just muted everyone.
Member
|
Something I noticed while testing. When you get force muted and see the notification, when you enable and/or disable your audio I think the notification should be killed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4052
Before the UI only allowed to send the
forceMutemessage to participants that were not muted. Now that moderators can mute all the other participants at once the message may be received by participants that are already muted, so it needs to be ignored in that case. Otherwise the user would see a You have been muted by a moderator notification even if already muted.Pending:
isAudioEnabledworks as expected