Show bridge process state and log #4083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
added
3. to review
enhancement
feature: integration 📦
src/components/RightSidebar/Matterbridge/MatterbridgeSettings.vue
Outdated
Show resolved
Hide resolved
…when token changes Signed-off-by: Julien Veyssier <[email protected]>
Member
Author
|
Here is a clarified version. Like you said, it's better if editBridge returns the state. So we now get process state every minute. The loop is relaunched when changing the room. We could use a much lower frequency. What do you think? |
Comment on lines
+80
to
+81
| $result = $this->bridgeManager->getBridgeProcessState($this->room); | ||
| return new DataResponse($result); |
Member
There was a problem hiding this comment.
Suggested change
| $result = $this->bridgeManager->getBridgeProcessState($this->room); | |
| return new DataResponse($result); | |
| $state = $this->bridgeManager->getBridgeProcessState($this->room); | |
| return new DataResponse($state); |
nickvergessen
approved these changes
Sep 3, 2020
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
LGTM but didn't execute
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matterbridge process state is updated and displayed when saving bridge config and when showing log file content.
Seeing log file content is mandatory when setting up Ms-teams as Matterbridge provides a link to finalize sign-in in those logs.
Not sure about the "show mattberbridge log" button text and location.