Skip to content

Add push to talk and push to mute #4328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcoambrosini merged 1 commit into from
Oct 9, 2020
Merged

Add push to talk and push to mute #4328

marcoambrosini merged 1 commit into from
Oct 9, 2020

Conversation

@marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented Oct 8, 2020

How to test: start a call with an active mic and press spacebar.

fix #603

Signed-off-by: Marco Ambrosini [email protected]

@marcoambrosini
Add push to talk and push to mute
fc0bdae 
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini marcoambrosini added this to the 💚 Next Major (21) milestone Oct 8, 2020
@marcoambrosini marcoambrosini self-assigned this Oct 8, 2020
danxuliu
danxuliu approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@marcoambrosini marcoambrosini merged commit 4da75d7 into master Oct 9, 2020
@marcoambrosini marcoambrosini deleted the feature/603/push-to-talk-mute branch October 9, 2020 07:30
@nickvergessen
Copy link
Member

nickvergessen commented Oct 9, 2020

Please document? Keyboard shortcuts in settings and maybe even the tooltip of the audio button?

@marcoambrosini
Copy link
Member Author

marcoambrosini commented Oct 9, 2020 •
edited
Loading

For the settings I was waiting for them to be in. Opened an issue so it doesn't get lost.

@marcoambrosini marcoambrosini mentioned this pull request Oct 9, 2020
Closed
@nickvergessen
Copy link
Member

nickvergessen commented Oct 14, 2020

When you push-to-talk and a moderator mutes you before you "release the key", you will be unmuted afterwards and have "push to mute". :/

@marcoambrosini marcoambrosini mentioned this pull request Oct 14, 2020
Closed
@nickvergessen nickvergessen mentioned this pull request Dec 18, 2020
Merged
This was referenced Feb 19, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danxuliu danxuliu danxuliu approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@marcoambrosini marcoambrosini

Labels

3. to review enhancement feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v11.0.0-alpha.1

Development

Successfully merging this pull request may close these issues.

Implement Push-To-Talk and Push-To-Mute

4 participants

@marcoambrosini @nickvergessen @danxuliu