Skip to content

Fix empty call background color #4408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 1 commit into from
Oct 19, 2020
Merged

Fix empty call background color #4408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/components/CallView/shared/EmptyCallView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export default {
}
</script>

<style lang="scss">
<style lang="scss" scoped>

.empty-call-view {
height: 100%;
Expand All @@ -157,7 +157,7 @@ export default {
flex-direction: column;
align-content: center;
justify-content: center;
color: var(--color-text-maxcontrast);
background-color: var(--color-loading-dark);
text-align: center;
.icon {
background-size: 64px;
Expand All @@ -168,5 +168,10 @@ export default {
button {
margin: 4px auto;
}

h2, p {
color: var(--color-primary-text);
Copy link
Member

@nickvergessen nickvergessen Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want white, not primary text, otherwise you have black text on dark grey background if your primary theming color is bright

Copy link
Member Author

@PVince81 PVince81 Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I hardcode white here ? then maybe I need to hardcode the background color as well instead of --color-loading-dark, if we agree that this is not something we want to theme.

as far as I can see here, only primary is defined: https://github.com/nextcloud/nextcloud-vue/blob/master/styleguide/assets/variables.css but if one would want to invert the colors they'd need to override "color-background-dark" with a light color ? or do we need a new primary-text-background color ?

Copy link
Member

@nickvergessen nickvergessen Oct 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont want the screen to be blue or something so we should not use anything related to primary.
Also we dont want it to flip ot white with dark mode, so mostlikely the loading color is wrong too.

But can be tested easily, just search for "accessibility" in your dev nextcloud, turn on dark mode, search for theming and use "#ffffff" as primary color and then start a call.

Expected result is a dark screen with readable font color

Copy link
Member

@nickvergessen nickvergessen Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nextcloud/server/blob/master/apps/accessibility/css/dark.scss#L16
Dark mode makes loading bright

Copy link
Member Author

@PVince81 PVince81 Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems that whatever combination of variables I pick, it cannot look good in both dark mode and regular mode

so if we anyway don't want to invert the colors I'll hardcode white and dark grey in this view

Copy link
Member Author

@PVince81 PVince81 Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> #4416

}
}

</style>