[stable20] Fix empty call view position in sidebar #4436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the call view is shown in the Files app or public share page sidebar its direct children (the empty call view and the wrapper of videos) are expected to have an absolute position. However, as the empty call view had a relative position it was prepended before the call view padding (which defines the call view height) instead of fully covering it. When the call view is shown in the main Talk UI or in the video verification sidebar the call view has an explicit height attribute (rather than using a padding), so in this case it does not matter if the empty call view has a relative or absolute position. However, when the empty call view is shown in the grid it must use a relative position. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
backportbot-nextcloud
bot
added
bug
feature: call 📹
backportbot-nextcloud
bot
requested review from
PVince81,
danxuliu and
marcoambrosini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #4429