Skip to content

Also delete the room if the last moderator leaves … #4489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 2 commits into from
Oct 30, 2020
Merged

Also delete the room if the last moderator leaves … #4489

nickvergessen merged 2 commits into from
Oct 30, 2020

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 29, 2020

Fix #4435

@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants labels Oct 29, 2020
@nickvergessen nickvergessen added this to the 💚 Next Major (21) milestone Oct 29, 2020
@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 29, 2020 •
edited
Loading

I found this while working on #4324 so no tests and stuff as we need to backport this and I dont want to make the rebase of the sip too complicated. I will create an issue to write respective tests later (#4490)

@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 29, 2020

/backport to stable20

@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 29, 2020

/backport to stable19

@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 29, 2020

/backport to stable18

@nickvergessen nickvergessen mentioned this pull request Oct 29, 2020
Closed
PVince81
PVince81 approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@nickvergessen
Keep file rooms
07fdbce 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen merged commit 9a45d13 into master Oct 30, 2020
@nickvergessen nickvergessen deleted the bugfix/4435/correctly-delete-conversations-when-last-moderator-leaves branch October 30, 2020 09:37
This was referenced Oct 30, 2020
Merged
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Oct 30, 2020

The backport to stable18 failed. Please do this backport manually.

@nickvergessen nickvergessen mentioned this pull request Oct 30, 2020
Merged
@nickvergessen nickvergessen mentioned this pull request Nov 16, 2020
Merged
@nickvergessen nickvergessen mentioned this pull request Jan 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danxuliu danxuliu Awaiting requested review from danxuliu

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

No one assigned

Labels

3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants

Projects

None yet

Milestone

v11.0.0-alpha.1

Development

Successfully merging this pull request may close these issues.

Regain access to a lost "chat"

3 participants

@nickvergessen @PVince81