-
Notifications
You must be signed in to change notification settings - Fork 508
🤙 SIP Bridge #4496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤙 SIP Bridge #4496
Conversation
8ef7ec6 to
84e5fca
Compare
|
|
{
event: {
flags: {
roomid: "1609407087",
sessionid: "hoB9bi9LhyJLVoZmcI_lswKJoOBfeHYCe31_ADaQaEt8UU9uM2tiajMyR2dOSWRvMFB5VS1abU9LbjM0TDNRN2l4eGp1Z21McDZlcDREUEdpWGFnQVRnX2t2R0lWWlR0eFp3SmpoTDZ2elN3aG1XeDJWTkd0UVdSanZlTVpvdFFuR1UyempIV0FEdzhHbVNvcHh5RHNqU2R2Yk1uT1pmdG9nUWloX1VvckRmV3pTUXd1UUVCQTlBengzMWpkRWFwLUx4TGswdkQ4fDAxMjk5NDQwNjE=",
flags: 1
}
target: "participants"
type: "flags"
}
type: "event"
} |
0c2bc8f to
0273263
Compare
|
8862f4e to
42ee9b2
Compare
This comment has been minimized.
This comment has been minimized.
120e2ef to
7a90854
Compare
|
Fixed guest identification. Works fine now, but there is a bug with the video background, as when we add in the user id later on, this part does not rerun with the new given user id: spreed/src/components/CallView/shared/VideoBackground.vue Lines 109 to 133 in 372990e
|
| $roomData['canEnableSIP'] = | ||
| $this->talkConfig->isSIPConfigured() | ||
| && ($room->getType() === Room::GROUP_CALL || $room->getType() === Room::PUBLIC_CALL) | ||
| && $currentParticipant->hasModeratorPermissions(false) | ||
| && $this->talkConfig->canUserEnableSIP($currentUser); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be also checked if the room token only contains digits (as otherwise Room::setSIPEnabled would fail)? Or that check is just an extra safety measure and configuring SIP automatically updates the previous room tokens, so if SIP is configured they will always be only digits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah right, let me check that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configuring SIP automatically updates the previous room tokens,
No way, as the token is used everywhere across clients and server to store information.
2f4ec36 to
fbfd005
Compare
danxuliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have NOT tested it, but code looks good.
There are some things that I would like to double check, but if they need any fixing we can handle them in follow-up pull requests.
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
…n the "after" event Signed-off-by: Joas Schilling <[email protected]>
…e conversation Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
…y as attendee Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
acab7e2 to
e83fbe7
Compare
e83fbe7 to
4766013
Compare
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
4766013 to
c287c0f
Compare
| ->with($sessionId) | ||
| ->willThrowException(new ParticipantNotFoundException()); | ||
| $room->expects($this->once()) | ||
| ->method('getParticipantBySession') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we tested the same function twice and that's why the tests failed before the last push
+49 1234 56789,00MEETINGID,PINTodos
Fix #1604
Fix #1605
Fix #1606
Fix #1607
Fix #1608
Fix #2511
Fix #2512