Skip to content

Fix user management in password request rooms #4656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 7 commits into from
Nov 27, 2020
Merged

Fix user management in password request rooms #4656

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
519960e
Make possible to verify room data also for single rooms
danxuliu Nov 12, 2020
b262d5f
Add integration tests for password request rooms
danxuliu Nov 20, 2020
88aa97a
Fix additional participants being able to join a password request room
danxuliu Nov 20, 2020
630e2f4
Fix owner being able to add more users to a password request room
danxuliu Nov 24, 2020
55d3fe2
Inform the user if an error occurred when adding participants
danxuliu Nov 24, 2020
44f3732
Do not show the search box in password request rooms
danxuliu Nov 24, 2020
cb7f80e
No participants means everything is okay
nickvergessen Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
No participants means everything is okay 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Nov 27, 2020
commit cb7f80e8acfd121fe8b0764b2e65da506341bdea
4 changes: 4 additions & 0 deletions lib/PublicShareAuth/Listener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,10 @@ public static function preventExtraUsersFromBeingAdded(Room $room, array $partic
return;
}

if (empty($participants)) {
return;
}

// Events with more than one participant can be directly aborted, as
// when the owner is added during room creation or a user self-joins the
// event will always have just one participant.
Expand Down