Skip to content

Load new participants by actor when the session does not exist yet #4682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Nov 27, 2020
Merged

Load new participants by actor when the session does not exist yet #4682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Load new participants by actor when the session does not exist yet 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Nov 27, 2020
commit 15fc38bf68c815fe1039e6280a6563b608ffdf1d
8 changes: 8 additions & 0 deletions lib/Controller/SignalingController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,14 @@ private function backendRoom(array $roomRequest): DataResponse {
try {
$participant = $room->getParticipantBySession($sessionId);
} catch (ParticipantNotFoundException $e) {
if ($action === 'join') {
// If the user joins the session might not be known to the server yet.
// In this case we load by actor information and use the session id as new session.
try {
$participant = $room->getParticipantByActor($actorType, $actorId);
} catch (ParticipantNotFoundException $e) {
}
}
}
} else {
try {
Expand Down