Use proc_open to run system commands in bridge manager #4746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
added
3. to review
enhancement
feature: integration 📦
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/improve-system-processes
branch
from
76fdf26 to
07650ec
Compare
nickvergessen
approved these changes
Dec 16, 2020
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
🐘 Christoph said it should be fine
Member
|
/backport to stable20 |
Member
|
❤️ |
Member
|
/backport to stable20.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies how we run commands and launch Matterbridge binary. It silences the processes. Output is now parsed with Php instead of using pipes, grep, awk and wc (which might all be missing on some systems).
refs #4743