Sync group members with conversation participants

[nickvergessen]

Fix #1329

• Use a shared method to handle add users of a group to a conversation
• Store groups as attendees for further usage
• Add users when they are added to a group
• Remove users when they are removed from a group and don't have another group that is a member
• Add integration tests for those things
• Do the same tracking with circles (if possible)
• Check all attendee places whether we should exclude groups (to gain performance)
• Make sure the display name is set for "group attendees"
• Make sure autocomplete doesn't suggest groups you already added
• Always show groups but at the end of the participant list
• 💭 groups should have 2 options or which one do we implement:
  • 1. Remove group only
  • 2. Remove group and also remove all members (that don't have another group)

[jancborchardt]

Should groups be always listed as participants, or only for moderators (or even only when searching?)

I’d say yes they should always be listed. Only showing them for certain people or when searching it would be a bit restrictive.
We can make sure they are distinct. For example we can do (either one or multiple of these):

• Have the list entries for groups on the bottom of the list – still visible but sort of out of the way (could also have an intermediate heading)
• Have a more distinct icon (primary color e.g.)
• A subline saying "23 participants" (or "members") which is informative and also separates it from the other entries

Should have 2 options on groups: 1. Remove, 2. Remove and also remove all members (that don't have another group)

I’d expect only one "Remove" action. If e.g. I added a dev, and also a group "Engineering" where the dev is in, and I remove the "Engineering" group, I would expect that the individually added dev should still be a member.

[nickvergessen]

I’d expect only one "Remove" action. If e.g. I added a dev, and also a group "Engineering" where the dev is in, and I remove the "Engineering" group, I would expect that the individually added dev should still be a member.

So let me draw a case:

• Group Engineering is users A, B, C
• I create a conversation
• I add user A
• I add group Engineering
• Now I, A, B and C are in
• I remove group Engineering
• Now we can have the result:
  • I, A, B and C (group members are not removed) or:
  • I (group members are removed)

Your comment is not explicit, I read it as you would like to have "I and A" but that is not going to work unless we add tones of additional logic and database entries.

[nickvergessen]

I currently went for "Remove group and also remove all members (that don't have another group)" because that is more in line with the expected behaviour that people are removed from chats when they are removed from a group and don't have another group in the chat. I think at this point it's more a matter of documentation and clarifying it in the UI maybe?

[nickvergessen]

But ready to review for now

[marcoambrosini]

Woooorks!

[nickvergessen]

After a discussion with jan we came to the conclusion that owners and moderators should not be dropped from the chat when their groups are removed. I will add that soon.

[nickvergessen]

run.sh: line 22: 533 Segmentation fault (core dumped) php -S localhost:8080 -t ${ROOT_DIR}**

Restarted the tests

[danxuliu]

Tested and works 👍

I left some comments, but they are not blockers.

[nickvergessen]

Updated

[danxuliu]

Tested and works 👍

[forlornidealist]

I know this is closed, but it does not seem to work with LDAP groups. If I add or remove a user to an LDAP group, they are not added/removed from the group chat like they are if I create the same group within Nextcloud manually. I will open a new issue for this, but for now I will create a script that creates a local group, named NC- that corresponds to each relevant AD group.