Do not load the blurred background source if not needed #4888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"blurredBackgroundImageSource" is not used when the CSS blur filter is used, so there is no need to load it in that case. This also fixes an error shown in older Edge versions (not Chromium-based) due to "createImageBitmap" not being available. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
feature: frontend 🖌️
Member
Author
|
/backport to stable20.1 |
Member
Author
|
/backport to stable20 |
marcoambrosini
approved these changes
Jan 7, 2021
danxuliu
deleted the
do-not-load-the-blurred-background-source-if-not-needed
branch
This was referenced Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4678
blurredBackgroundImageSourceis not used when the CSS blur filter is used, so there is no need to load it in that case.This also fixes an error shown in older Edge versions (not Chromium-based) due to
createImageBitmapnot being available.