Unregister "refreshPeerList" event when CallView is destroyed #4889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no "unmounted" lifecycle hook in Vue; after a component is mounted it can only be destroyed. This fixes a memory leak of the CallView, as the reference was retained forever by the EventBus. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
regression
feature: frontend 🖌️
Member
Author
|
/backport to stable20.1 |
nickvergessen
approved these changes
Jan 5, 2021
nickvergessen
deleted the
unregister-refreshpeerlist-event-when-callview-is-destroyed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4685
There is no
unmountedlifecycle hook in Vue; after a component is mounted it can only be destroyed.This fixes a memory leak of the CallView, as the reference was retained forever by the EventBus.