Skip to content

Cannot disable sip #4951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 2 commits into from
Jan 14, 2021
Merged

Cannot disable sip #4951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
041a340
Fix disabling SIP
nickvergessen Jan 14, 2021
e3c3c3d
Remove copy-pasta code from origin component
nickvergessen Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/components/ConversationSettings/LockingSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,20 +68,6 @@ export default {
},
},

watch: {
value(value) {
this.listable = value
},
},

mounted() {
if (this.token) {
this.listable = this.value || this.conversation.listable
} else {
this.listable = this.value
}
},

methods: {
async toggleReadOnly() {
const newReadOnly = this.isReadOnly ? CONVERSATION.STATE.READ_WRITE : CONVERSATION.STATE.READ_ONLY
Expand Down
8 changes: 4 additions & 4 deletions src/components/ConversationSettings/SipSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,20 +64,20 @@ export default {
},

methods: {
async toggleSIPEnabled(checked) {
async toggleSIPEnabled() {
try {
await this.$store.dispatch('setSIPEnabled', {
token: this.token,
state: checked ? WEBINAR.SIP.ENABLED : WEBINAR.SIP.DISABLED,
state: !this.conversation.sipEnabled ? WEBINAR.SIP.ENABLED : WEBINAR.SIP.DISABLED,
})
if (checked) {
if (this.conversation.sipEnabled) {
showSuccess(t('spreed', 'SIP dial-in is now enabled'))
} else {
showSuccess(t('spreed', 'SIP dial-in is now disabled'))
}
} catch (e) {
// TODO check "precondition failed"
if (checked) {
if (!this.conversation.sipEnabled) {
console.error('Error occurred when enabling SIP dial-in', e)
showError(t('spreed', 'Error occurred when enabling SIP dial-in'))
} else {
Expand Down