Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 27, 2021

Sample request:

curl -k https://localhost/ocs/v2.php/apps/spreed/api/v1/chat/XXXXX/share \
    -u admin:admin \
    -H "OCS-ApiRequest: true" \
    -d 'objectType=deck-card'\
    -d 'objectId=9'\
    -d 'metaData={"type":"deck-card","id":"9","name":"Card title","boardname":"Board name","stackname":"Stack name","link":"https:\/\/nextcloud21.local\/index.php\/apps\/deck\/#\/board\/2\/card\/9"}'

Bildschirmfoto von 2021-01-27 14-51-01

As per discussion in the chat, for now it is "garbage-in garbage-out". The resolution for that is extending the rich-object part in the server to allow to "parse"/"verify" data by each app even allowing them to return "Not accessible" or something alike as currently hard coded for files.

  • Allow posting rich-object
  • Parse rich-objects
  • Add test
  • Add integration test
  • Add documentation
  • Add capability

@nickvergessen
Copy link
Member Author

Documented, tests added and capability added for clients.

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, see minor comments.

@PVince81
Copy link
Member

@nickvergessen One question also while grepping for {file} I saw that there was a special handling in Quote.vue, is that one necessary also for {object} ?

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does what it says!

@nickvergessen
Copy link
Member Author

One question also while grepping for {file} I saw that there was a special handling in Quote.vue, is that one necessary also for {object} ?

That's to show the preview instead of the file name. For now the card name is good enough. When we improve styling of deck cards we can revisit this.

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking while finishing to style the card component

@nickvergessen nickvergessen force-pushed the feature/noid/allow-sharing-rich-objects-to-chats branch from fcf356e to aebc61c Compare February 2, 2021 15:25
@nickvergessen
Copy link
Member Author

Rebased

@nickvergessen nickvergessen merged commit f6008b9 into master Feb 3, 2021
@nickvergessen nickvergessen deleted the feature/noid/allow-sharing-rich-objects-to-chats branch February 3, 2021 15:17
@nickvergessen
Copy link
Member Author

/backport to stable21.1

@nickvergessen
Copy link
Member Author

/backport to stable21.1

@backportbot-nextcloud
Copy link

The backport to stable21.1 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release enhancement feature: chat 💬 Chat and system messages feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants