-
Notifications
You must be signed in to change notification settings - Fork 509
Allow to share RichObjects to chats #5034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to share RichObjects to chats #5034
Conversation
|
Documented, tests added and capability added for clients. |
PVince81
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, see minor comments.
|
@nickvergessen One question also while grepping for |
marcoambrosini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does what it says!
That's to show the preview instead of the file name. For now the card name is good enough. When we improve styling of deck cards we can revisit this. |
marcoambrosini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking while finishing to style the card component
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
fcf356e to
aebc61c
Compare
|
Rebased |
|
/backport to stable21.1 |
|
/backport to stable21.1 |
|
The backport to stable21.1 failed. Please do this backport manually. |
Sample request:
As per discussion in the chat, for now it is "garbage-in garbage-out". The resolution for that is extending the rich-object part in the server to allow to "parse"/"verify" data by each app even allowing them to return "Not accessible" or something alike as currently hard coded for files.