Mention sub name users #5041
Merged
Mention sub name users #5041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
force-pushed
the
bugfix/noid/mention-sub-name-users
branch
from
f26714c to
98a4270
Compare
Member
Author
|
/backport to stable20.1 |
Member
Author
|
/backport to stable20 |
blizzz
approved these changes
Jan 28, 2021
danxuliu
requested changes
Jan 28, 2021
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Using \b (word boundary)) does not cover all the valid characters in a user name. I have added unit tests that show the issue.
Member
Author
|
Then I guess we should indeed sort by length first, because |
danxuliu
approved these changes
Jan 29, 2021
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Tests pass and code looks good.
Allowing quotes also for user names without spaces should be fine, so 👍
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/mention-sub-name-users
branch
from
a08d0f9 to
e65fa8d
Compare
Member
Author
|
Fixing up |
This was referenced Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Mention to @sub and @subnameMention to @subname and @sub