Skip to content

Conversation

@nickvergessen
Copy link
Member

Steps

  1. Add breakpoint at
    $activeSince = $room->getActiveSince();
  2. Add breakpoint at
    $numGuests = $room->getActiveGuests();
  3. Start a call with 2 users
  4. Leave call with both users
  5. Wait until both requests are at breakpoint 1
  6. Wait until both requests are at breakpoint 2
  7. Request 1 step until
    $actorId = $userIds[0] ?? 'guests-only';
  8. Request 2 step and and it should return on
    return false;

Before this PR you will not enter the if in request 2 and therefor generate 2 call summaries

Signed-off-by: Joas Schilling <[email protected]>
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 as discussed

@nickvergessen
Copy link
Member Author

/backport to stable20.1

@nickvergessen
Copy link
Member Author

/backport to stable20

Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (with SQLite) and works 👍 Code makes sense.

@nickvergessen nickvergessen merged commit f86bc4a into master Jan 29, 2021
@nickvergessen nickvergessen deleted the bugfix/noid/prevent-duplicate-call-summaries branch January 29, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants