Fix "Talk/ folder not working for attachments" #5076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
3. to review
bug
feature: upload & shares & voice 📤🎙️
nickvergessen
requested review from
PVince81,
danxuliu,
juliusknorr and
rullzer
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20.1 |
Member
Author
|
/backport to stable20 |
Member
Author
|
/backport to stable19 |
PVince81
approved these changes
Feb 3, 2021
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 makes sense, app types are needed to catch certain events.
This wouldn't be the first time.
PVince81
deleted the
bugfix/noid/fix-Talk-folder-sometimes-not-working-for-attachments
branch
This was referenced Feb 3, 2021
This was referenced Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I'm pretty sure this is the fix.
Attachment folder worked 100% of the time I tested deck, which does everything exactly the same, but is already registered as "dav" because it uses the dav API of comments?
https://github.com/nextcloud/deck/blob/b0135a71ede5eb1d95d9aa9b1b6ceb458c8198ce/appinfo/info.xml#L25
After some logging and debugging I could confirm that in the broken cases the write was ALWAYS on a propfind from the desktop client and logging at:
https://github.com/nextcloud/server/blob/d89a75be0b01f0423a7c1ad2d58aac73c3cc1f3a/apps/files_sharing/lib/SharedMount.php#L119
Confirmed
OC_App::isAppLoaded()is false for "spreed" and true for "deck". I uploaded 3 more files after changing this on c.nc.c and they all worked, even though the request was from the client.So the problem was Talk didn't react on the event and change the path to
Talk/, but was still invoked to update the share afterwards (which made me assume it should be working, but reality now proofed different)¯\_(ツ)_/¯