Skip to content

[stable21] Add support for "turns:" scheme #5087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danxuliu merged 3 commits into from
Feb 5, 2021
Merged

[stable21] Add support for "turns:" scheme #5087

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcc48cf
Add support for "turns:" scheme
danxuliu Oct 29, 2020
36d4d78
Show warning when "turns:" is used with IP addresses
danxuliu Feb 5, 2021
ce3910a
Add "stun:" scheme literal
danxuliu Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add "stun:" scheme literal 
The STUN scheme can not be specified (browsers do not support "stuns:"),
but a literal text was added to clarify that the scheme does not need to
be included in the input field.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu @backportbot
danxuliu authored and backportbot[bot] committed Feb 5, 2021
commit ce3910a8d59b3bc1bcb0278f08194e042a9448b4
7 changes: 7 additions & 0 deletions src/components/AdminSettings/StunServer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@

<template>
<div class="stun-server">
<!-- "stun:" scheme is untranslated -->
<span class="scheme">stun:</span>
<input ref="stun_server"
type="text"
name="stun_server"
Expand Down Expand Up @@ -96,6 +98,11 @@ export default {
</script>

<style lang="scss" scoped>
.scheme {
/* Same margin as inputs to keep the style. */
margin: 3px 3px 3px 0;
}

.stun-server {
height: 44px;
display: flex;
Expand Down