Prevent current page in grid to become negative #5101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the number of pages was -1 (which happens if there are no remote videos and thus "slots" becomes -1) the current page became -2. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
regression
feature: frontend 🖌️
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20.1 |
nickvergessen
approved these changes
Feb 9, 2021
nickvergessen
deleted the
prevent-current-page-in-grid-to-become-negative
branch
This was referenced Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced in #4958
If the number of pages was -1 (which happens if there are no remote videos and thus "slots" becomes -1) the current page became -2.
How to test
Result with this pull request
In the original window the guest is shown.
Result without this pull request
In the original window the guest is not shown. Changing to speaker mode and then back to grid view shows the guest again (because that resets currentPage to 0).