Make sure that project resources scripts event is properly emitted #5105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
force-pushed
the
bugfix/noid/collections
branch
from
04f83dc to
cde349f
Compare
nickvergessen
approved these changes
Feb 10, 2021
Member
|
/backport to stable21 |
Member
|
/backport to stable20.1 |
Member
|
/backport to stable20 |
Member
|
/backport to stable19 |
Member
Author
|
👍 |
3 tasks
Member
|
please rebase, the tests should pass now that they were fixed on master |
Signed-off-by: Julius Härtl <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/collections
branch
from
cde349f to
86d7798
Compare
This was referenced Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user_uiddoesn't seem to be set automatically, so the event to dispatch for loading scripts for the projects integration is never emitted (in tempates/index.php)I can't find where this broke currently so there might be a different way to solve this depending on what changed, however this at least makes it work again :)