Provide information for incoming call screens #5129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
bug
feature: api 🛠️
Member
Author
|
Currently clients (web and ios tested) seem to always join the call without a parameter so all are added as |
PVince81
approved these changes
Feb 11, 2021
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
Looks fine 👍
See minor comments
nickvergessen
force-pushed
the
feature/4931/provide-information-for-incoming-call-screen
branch
from
22576aa to
676623e
Compare
Member
Author
|
Fixed the comments and rebased on the fixed integration tests |
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
feature/4931/provide-information-for-incoming-call-screen
branch
from
676623e to
bf5f69c
Compare
nickvergessen
deleted the
feature/4931/provide-information-for-incoming-call-screen
branch
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable21.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4931