Prevent loading old messages twice on scroll #5198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever the old messages are already loading initially when opening a conversation, a scroll event might call getOldMessages again which would cancel the previous one. The initial old messages load is using includeLastKnown=1 while the others use 0. So if it gets cancelled, we will miss the "last known" message as it won't be included in subsequent calls. This fix prevents repeated calls to getOldMessages to avoid the above issue. Signed-off-by: Vincent Petry <[email protected]>
Member
|
Ay that's what I'm always experiencing |
| // Make the request | ||
| try { | ||
| const messages = await request({ token, lastKnownMessageId, includeLastKnown: includeLastKnown ? '1' : '0' }) | ||
| this.oldMessagesPromise = request({ token, lastKnownMessageId, includeLastKnown: includeLastKnown ? '1' : '0' }) |
Member
There was a problem hiding this comment.
the component is reused, so you need to store this based on token?
Otherwise if you quickly change to 2 unloaded conversations the second one wouldn't load?
Member
There was a problem hiding this comment.
Or more simply reset the value to null when the token changes?
Member
Author
There was a problem hiding this comment.
if you switch to another conversation the call will get cancelled anyway, so you'll then get a new request
nickvergessen
approved these changes
Feb 19, 2021
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Nice one, seems to work
nickvergessen
deleted the
bugfix/noid/prevent-double-request-cancel-on-scroll
branch
Member
|
Queuing backport for after 11.0.0 is out |
Member
|
/backport to stable21.1 |
nickvergessen
added
backport-request
feature: chat 💬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the old messages are already loading initially when opening a
conversation, a scroll event might call getOldMessages again which would
cancel the previous one.
The initial old messages load is using includeLastKnown=1 while the others use
0. So if it gets cancelled, we will miss the "last known" message as it
won't be included in subsequent calls.
This fix prevents repeated calls to getOldMessages to avoid the above
issue.
See #3825 (comment) for semi-reliable reproduction steps and #3825 (comment) for some information.
The handleScroll method was sometimes calling getOldMessages(false) while we still had getOldMessages(true), which led to having a missing message in the list. Usually the one with the read marker, hence why I discovered it only in the PR above.
With a bit of luck this might also fix #5188 as it will also prevent repeated calls to getOldMessages(false) if scrolling up/down multiple times when at the top of the container.