[stable21.1] Add sharing deck card with a conversation #5202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
PVince81,
juliusknorr,
marcoambrosini and
nickvergessen
Added deck action for sharing/linking that uses the RoomSelector. Improved RoomSelector Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Vincent Petry <[email protected]>
Deck plugin now creates its own Vue VM to instantiate the RoomSelector. RoomSelector now allows to specify properties for dialog title and whether the result list should be filtered. Signed-off-by: Vincent Petry <[email protected]>
Expose the Talk Vue instance on OCA.Talk.instance. In RoomSelector, grab the current room from that instance to filter it out, when applicableRemove current room from RoomSelector Expose the Talk Vue instance on OCA.Talk.instance. In RoomSelector, grab the current room from that instance to filter it out, when applicable. Signed-off-by: Vincent Petry <[email protected]>
nickvergessen
force-pushed
the
backport/5110/stable21.1
branch
from
68d3b0e to
f3b16f3
Compare
nickvergessen
approved these changes
Feb 19, 2021
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Redid the cherry-picking as there was a conflict in Application class (displayname change listener is not there)
Works now
This was referenced Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #5110