When locking a conversation, kick out everyone #5215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also only trigger events and update the session flags if they actually changed, as some callers might not check for differences. Signed-off-by: Vincent Petry <[email protected]>
In the settings dialog there are now warnings to tell that people will be removed from calls when either enabling the lobby or locking a conversation. Signed-off-by: Vincent Petry <[email protected]>
Member
Author
|
|
Member
Author
|
@nickvergessen please review. Does this still have high priority ? |
nickvergessen
requested changes
Feb 25, 2021
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
I would backport it to 21.1 branch
Member
Author
|
pushed
|
Member
Author
|
/backport to stable21.1 |
Only show ongoing call warnings in settings dialog when a call is actually in progress. Signed-off-by: Vincent Petry <[email protected]>
PVince81
force-pushed
the
bugfix/5192/force-leave-on-lock
branch
from
4f95ea0 to
e511e5d
Compare
Member
Author
|
squashed the typo fixes into the last commit |
nickvergessen
approved these changes
Mar 1, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also only trigger events and update the session flags
if they actually changed, as some callers might not check for differences.
confirmation dialog (separately is also ok if not urgent)warning in text