Skip to content

Use addMessageForAllParticipants instead of looping manually #5257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Feb 24, 2021
Merged

Use addMessageForAllParticipants instead of looping manually #5257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use addMessageForAllParticipants instead of looping manually 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Feb 24, 2021
commit 81520a678910fec10750e446ef08e989650a85cb
11 changes: 1 addition & 10 deletions lib/Signaling/Listener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,16 +100,7 @@ protected static function registerInternalSignaling(IEventDispatcher $dispatcher

/** @var Messages $messages */
$messages = \OC::$server->query(Messages::class);
/** @var ParticipantService $participantService */
$participantService = \OC::$server->query(ParticipantService::class);

$participants = $participantService->getParticipantsForRoom($room);
foreach ($participants as $participant) {
$session = $participant->getSession();
if ($session instanceof Session) {
$messages->addMessage($session->getSessionId(), $session->getSessionId(), 'refresh-participant-list');
}
}
$messages->addMessageForAllParticipants($room, 'refresh-participant-list');
};
$dispatcher->addListener(Room::EVENT_BEFORE_ROOM_DELETE, $listener);
}
Expand Down