copy msg link to clipboard

[jakobroehrl]

Signed-off-by: Jakob Röhrl [email protected]
solves: #5097

[nickvergessen]

So with more and more actions (delete, deck-integration, reply-private, copy link) I think the most used action (reply) is getting moved to far away as you always need to open the ... first.
cc @ma12-co @jancborchardt any clever ideas how we can make replying quick again?

[PVince81]

So with more and more actions (delete, deck-integration, reply-private, copy link) I think the most used action (reply) is getting moved to far away as you always need to open the ... first.
cc @ma12-co @jancborchardt any clever ideas how we can make replying quick again?

we probably need a second button just for replying.
and the three dots menu directly after that

[jancborchardt]

So with more and more actions (delete, deck-integration, reply-private, copy link) I think the most used action (reply) is getting moved to far away as you always need to open the ... first.

@nickvergessen Thought exactly the same, yep.

we probably need a second button just for replying.
and the three dots menu directly after that

@PVince81 exactly that – just like we do in files too, or e.g. in the left navigation of calendar, in both cases where "Share" is a direct action. In this case "Reply" will be the direct action, and everything else is details.

[marcoambrosini]

Agree, should we create a separate ticket for this?

[nickvergessen]

yeah, it shouldn't block a "random" pr adding another action

[nickvergessen]

Reported #5297

[jakobroehrl]

added it to the new action menu:

[PVince81]

nice!

I'm starting to wonder if we should start to add some separators in there, maybe to separate the hard-coded actions from the registered ones.

@ma12-co any thoughts on this ? (see above screenshot)

[marcoambrosini]

Yep, we could have something like:

talk actions
---
other apps actions 
---
delete 

[PVince81]

@jakobroehrl do you want to take care of the separators or is this something for another PR ?

note: there are like more actions coming

[jakobroehrl]

@jakobroehrl do you want to take care of the separators or is this something for another PR ?

note: there are like more actions coming

I will try the seperators here in this PR

Could you say me the actions, maybe I can help with the easy ones?

[PVince81]

Could you say me the actions, maybe I can help with the easy ones?

I have a PR that will bring "mark as unread" here later on: #3825.
I thought there were other already open PRs with more actions, not sure. In any case if we add separators as @ma12-co we can insert the new actions in the places that make sense between/after/before the separators.

[jakobroehrl]

supernice :)
Let's merge it?

[jakobroehrl]

I have a PR that will bring "mark as unread" here later on: #3825.

@PVince81 Maybe I can do this? Please ping me if it's easy and when I can start

[PVince81]

I have a PR that will bring "mark as unread" here later on: #3825.

@PVince81 Maybe I can do this? Please ping me if it's easy and when I can start

@jakobroehrl I already created the action there, thanks :-)

The only thing you can do right now is add the separators as @ma12-co advised. I'd say put them in this PR here.
Future work can then decide where to put new actions.

[PVince81]

okay, you added already. let me review!

[PVince81]

👍

[marcoambrosini]

Nice work @jakobroehrl :)
One question, I'm not able to copy links of my own messages, I think it would be nice to be able to do so too. Is there a particular reason why this wasn't implemented?

As a side note, I also think that we should use var(--color-primary-light) for the fading feedback on the target message to give some more emphasis and differentiate it from the messages hover/focus feedbacks.

[jakobroehrl]

Nice work @jakobroehrl :)
One question, I'm not able to copy links of my own messages, I think it would be nice to be able to do so too. Is there a particular reason why this wasn't implemented?

Thanks! :)
That's a bug, fixed it.

As a side note, I also think that we should use var(--color-primary-light) for the fading feedback on the target message to give some more emphasis and differentiate it from the messages hover/focus feedbacks.

Sorry, what do you mean here? What exactly should I change?

[marcoambrosini]

That's a bug, fixed it.

Noice :)

Sorry, what do you mean here? What exactly should I change?

Basically those 3 variables in the animation into var(--color-primary-light)

https://github.com/nextcloud/spreed/blob/master/src/components/MessagesList/MessagesGroup/Message/Message.vue#L750