[stable21.1] Fix redirect when deleting current conversation #5315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
PVince81,
danxuliu and
nickvergessen
When the current conversation was deleted while in a call, or whenever someone has been removed from a room, the redirect now targets the not-found page instead of the one about duplicate session. Signed-off-by: Vincent Petry <[email protected]>
PVince81
force-pushed
the
backport/5082/stable21.1
branch
from
88a0245 to
cc292ce
Compare
Member
|
conflict solved by cherry-picking the commit from #5289 which is closed code-wise |
Member
|
@nickvergessen @ma12-co please review, conflict was solved |
Member
|
Btw there is a difference now. Before the page title e.g. was cleared, with your PR it still contains the room name. |
Member
|
So merge or not, that is the question? |
Member
|
I've now pushed a fix for the window title here: #5487 |
Member
|
we can merge this here and then backport the other fix once ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #5082