New messages indicator while in call #5534
Conversation
|
@ma12-co I'm unsure about the bubble alignment. It needs to be positioned in a way that it still looks nice when there are more digits. Also: I had to reuse the "AppNavigationCounter" outside the app navigation because somehow we didn't make that a generic numbers bubble component ? |
|
PR for CounterBubble: nextcloud-libraries/nextcloud-vue#1895 |
|
Requirement is full filled, so this can be finished? |
oh, yes, finally!! |
PVince81
force-pushed
the
enh/3110/in-call-new-messages-indicator
branch
from
18dd122 to
2af8a2e
Compare
|
rebased and retested, seems to work. however can't test for too long due to the unrelated scrolling regression: #5747 |
|
@PVince81 could we use a chat icon as default icon while in call, instead of the sidebar-participants hybrid one? like |
I've just tried this locally and it seems the Actions component is very glitchy. When starting the call the icon doesn't appear even though the Vue inspector tells me the MessageTextIcon is there. And then when I leave the call, the icon is still there even though |
|
what the hell, ghost components... |
|
I wonder if it's a bug in the vue transition and that it mistakenly fails to remove the DOM element even though the component is not there any more. But I haven't found where the right sidebar transition is defined to disable it for testing. Worst case I replace the material design icon with a regular one... |
|
and here the glitch where the Actions render the single ActionButton hidden the first time:
|
|
alright, I managed to get rid of the glitches by setting "key" attributes on the buttons... I'll do more testing then push |
PVince81
force-pushed
the
enh/3110/in-call-new-messages-indicator
branch
from
2af8a2e to
e3113d8
Compare
|
rebased and adjusted, changes:
|
|
When the first message is a mention I get this:
Otherwise looks like a solid idea |
I thought this is what you wanted when you commented on the line that had "unreadMessages > 1" instead of "> 0". If that's a concern I can make the messages to be a single one again, with "you have been mentionned" with higher priority. |
|
What I ment was:
What I didn't mean:
|
|
now thinking, I could simply store the notification handle and hide it to make sure that we only ever see one notification. so in the first scenario you'd only see "you have been mentioned" at the end. |
Which is fine, but when there were like 5 mins between the normal message and a mention its good to reping I guess. That's why I ment that 2 notifications are prolly fine |
Yes. I've just pushed after testing and this is how it behaves now. |
|
unit test added for the messages store adjustments. TopBar component tests have not been bootstrapped yet, maybe in a separate PR |
There was a problem hiding this comment.
I slightly modified the position of the icon and the counter.
One thing I'm not convinced is the toast for new messages. I think it's really invasive, especialle because it covers buttons making them unclickable. I'd much rather leave it as is or add a subtle animation to the counter each time the number increases. What do you think?
When in a call and the sidebar is collapsed, whenever new unread messages arrive, a bubble will be displayed on top of the button that opens the sidebar. If a mention exists, the bubble will appear highlighted. Whenever a new unread message or new mention arrives while in a call with the sidebar closed, a notification will appear once. Signed-off-by: Vincent Petry <[email protected]> Co-authored-by: Joas Schilling <[email protected]>
Replace icon with MessageText when in call. Counter bubble now lets hover and click through. Display two notifications when mentionned. Signed-off-by: Vincent Petry <[email protected]>
As soon as we receive new messages from the "lookForNewMessages" action, they are counted and added to the number of known unread messages. This makes the store update and counter in the left sidebar update more quickly. Signed-off-by: Vincent Petry <[email protected]>
When fetching new messages in the current conversation, also scan them for mentions to update the conversation store's unreadMention flag if necessary. This makes a mention notification or the counter bubble highlight color update more quickly without having to wait for the conversation list reload. Signed-off-by: Vincent Petry <[email protected]>
Adjust icon size. Prevent double notification. Signed-off-by: Vincent Petry <[email protected]>
Only show one notification for unread messages, either for new messages or for mentions. When switching from "new messages" to "you have been mentionned", discard the former notification. Signed-off-by: Vincent Petry <[email protected]>
Minor fixes to messagesStore unread messages counter logic. Added tests for all cases. Signed-off-by: Vincent Petry <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
PVince81
force-pushed
the
enh/3110/in-call-new-messages-indicator
branch
from
f83268d to
df04143
Compare
This is a general problem, also when having connection issues or device issues. To fix the messed up rebase, I force pushed my local work and then cherry-picked your last commit, then rebased again. |
|
for the toast notification, I found the "selector" attribute, but setting it to "#call-container" didn't shift it. |
|
@marcoambrosini I managed to shift the notification down, see #5794 |
Fixes #3110
When the sidebar is closed while in call, there will be an unread messages counter on top of the "open sidebar" button:
It is blue for new mentions and grey if there are no mentions.
Additionally, the first time a new unread message arrives or a new mention, a notification will be displayed.