[stable21.1] Fix quality warning tooltip not staying dismissed #5552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
added
bug
feature: call 📹
backportbot-nextcloud
bot
requested review from
PVince81,
danxuliu,
marcoambrosini and
nickvergessen
nickvergessen
requested changes
May 3, 2021
| lastIsStripeOpen: null, | ||
| presentationStarted: false, | ||
| selectedVideoPeerId: null, | ||
| qualityWarningTooltipDismissed: false, |
Member
There was a problem hiding this comment.
getter is missing in the backport:
isQualityWarningTooltipDismissed: (state) => state.qualityWarningTooltipDismissed,The flag that keep track of whether the quality warning tooltip was dismissed was a local data of the LocalMediaControls component, so it was reset when a new instance of the component was created again. As a new instance could be created several times during the same call (for example, when switching between speaker and grid mode) the warning tooltip could appear again after being dismissed. Now the flag is kept in the store and shared between different instances. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
backport/5550/stable21.1
branch
from
1d0cf01 to
b353501
Compare
danxuliu
approved these changes
May 3, 2021
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Conflicts fixed.
Tested and works 👍
nickvergessen
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #5550