Reusable user ids one to one chats #5633
Conversation
nickvergessen
added
3. to review
bug
feature: api 🛠️
|
|
||
| $leftRooms = $this->manager->getLeftOneToOneRoomsForUser($user->getUID()); | ||
| foreach ($leftRooms as $room) { | ||
| $room->setType(Room::GROUP_CALL, true); |
There was a problem hiding this comment.
this means other users could be invited to that conversation and then they could read past messages, feels like an unwanted side effect.
if we had a way to mark it as archived, like read-only mode but would need an external system user moderator then to prevent anyone to remove there read-only flag
There was a problem hiding this comment.
No one cares? Don't want to make it overly complicated so that is good enough. Before you could do screenshares and share them already ¯\_(ツ)_/¯
I'm fine with marking it archived by default as well. We could also "demote" the other user to be a normal user and they can then leave the conversation only. But simplicity is the key here I think.
There was a problem hiding this comment.
I've tested it and seems fine then.
A good thing is that now that it's a group conversation, the remaining user is able to delete it also.
nickvergessen
force-pushed
the
bugfix/noid/reusable-user-ids-one-to-one-chats
branch
from
74c4c4a to
e7ef6cc
Compare
|
Failing sharing tests are fixed in #5634 |
Signed-off-by: Joas Schilling <[email protected]>
… can't join again Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/reusable-user-ids-one-to-one-chats
branch
from
e7ef6cc to
3e88db0
Compare
|
/backport to stable21.1 |
No description provided.