Encode dav path segments for direct preview #5673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
reviewed
May 27, 2021
src/components/MessagesList/MessagesGroup/Message/MessagePart/FilePreview.vue
Outdated
Show resolved
Hide resolved
Member
Author
|
hold on, we have unit tests for this class now, I'll add one to cover the encoding |
Signed-off-by: Vincent Petry <[email protected]>
PVince81
force-pushed
the
bugfix/5672/fix-dav-path-encoding
branch
from
98c4fe5 to
acf697d
Compare
Member
Author
|
alright, added test and also adjusted the guest path |
marcoambrosini
approved these changes
May 27, 2021
Member
Author
|
/backport to stable21.1 |
Member
Author
|
/backport to stable21 |
|
The backport to stable21.1 failed. Please do this backport manually. |
Member
Author
|
stable21.1: #5674 the stable21 backport will be initiated from that PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5672