Fall back get participant in case session is gone #5738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some concurrent request scenarios, the session of a participant might expire just after its id got retrieved. To avoid unexpected behavior, if the participant could not be found by session id, fall back to getting it by user id. Fixes issue where a room can sometimes not be deleted from the UI due to a concurrent request that removes the session id. Signed-off-by: Vincent Petry <[email protected]>
Member
Author
|
/backport to stable21.1 |
nickvergessen
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some concurrent request scenarios, the session of a participant might
expire just after its id got retrieved. To avoid unexpected behavior, if
the participant could not be found by session id, fall back to getting
it by user id.
Fixes issue where a room can sometimes not be deleted from the UI due to
a concurrent request that removes the session id.
Fixes #5733