Ignore current participant when listing rooms if removed concurrently #5750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When retrieving the conversation list for a user, there is a time window between retrieving the list and the participant information. If in that time window, a concurrent request removes the user from the room, or even the room got deleted, this could cause a ParticipantNotFoundException. This fix prevents the latter exception to make the whole call return a 404. Instead, it skips the obsoleted entry and carries on with the list. Signed-off-by: Vincent Petry <[email protected]>
PVince81
changed the title
Member
Author
|
/backport to stable21.1 |
nickvergessen
approved these changes
Jun 14, 2021
nickvergessen
deleted the
bugfix/noid/ignore-removed-participant-when-listing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrieving the conversation list for a user, there is a
time window between retrieving the list and the participant information.
If in that time window, a concurrent request removes the user from the
room, or even the room got deleted, this could cause a
ParticipantNotFoundException.
This fix prevents the latter exception to make the whole call return a
404. Instead, it skips the obsoleted entry and carries on with the list.
Similar race condition like with #5733.
Not reproducible though.