[stable21.1] Fix connection quality stats not reset when setting a new peer connection #5767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The stats needs to be reset when a peer connection starts. The stats from the previous peer connection are unrelated to the new one, and that will cause a wrong analysis until the stats are filled again with values from the new peer connection. Similarly, the stats should be reset too when a peer connection is restarted. In this case the reported stats continue from the last values. However, during the reconnection the stats will not be updated, so the timestamps will suddenly increase once the connection is ready again, which could cause a wrong analysis. Due to all that now the stats are reset before the analysis is started, as the analysis is started only when the peer connection is started or restarted. Note that right now the sender connections with the HPB are never restarted; a new peer connection is always established. Nevertheless, this approach should be more "future proof". Signed-off-by: Daniel Calviño Sánchez <[email protected]>
This is just for tidyness, as stats for screen streams only contain data for video, and thus in practice this change makes no difference. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
backportbot-nextcloud
bot
added
bug
feature: call 📹
nickvergessen
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #5751