Skip to content

[stable20] Fix connection quality stats not reset when setting a new peer connection #5769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danxuliu merged 3 commits into from
Jun 14, 2021
Merged

[stable20] Fix connection quality stats not reset when setting a new peer connection #5769

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f13a69
Extract method to reset stats
danxuliu Jun 11, 2021
a58286c
Reset stats before the analysis is started
danxuliu Jun 11, 2021
a668afa
Set explicitly the media to be analyzed in screens
danxuliu Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Set explicitly the media to be analyzed in screens 
This is just for tidyness, as stats for screen streams only contain data
for video, and thus in practice this change makes no difference.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu @backportbot
danxuliu authored and backportbot[bot] committed Jun 14, 2021
commit a668afa2ea4d60cb387251beaaf3ea31a475a789
6 changes: 6 additions & 0 deletions src/utils/webrtc/analyzers/ParticipantAnalyzer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,12 +257,18 @@ ParticipantAnalyzer.prototype = {
this._senderScreenPeerConnectionAnalyzer.setPeerConnection(this._screenPeer.pc, PEER_DIRECTION.SENDER)

this._senderScreenPeerConnectionAnalyzer.on('change:connectionQualityVideo', this._handleConnectionQualityScreenChangeBound)

this._senderScreenPeerConnectionAnalyzer.setAnalysisEnabledAudio(false)
this._senderScreenPeerConnectionAnalyzer.setAnalysisEnabledVideo(true)
}

if (this._callParticipantModel) {
this._receiverScreenPeerConnectionAnalyzer.setPeerConnection(this._screenPeer.pc, PEER_DIRECTION.RECEIVER)

this._receiverScreenPeerConnectionAnalyzer.on('change:connectionQualityVideo', this._handleConnectionQualityScreenChangeBound)

this._receiverScreenPeerConnectionAnalyzer.setAnalysisEnabledAudio(false)
this._receiverScreenPeerConnectionAnalyzer.setAnalysisEnabledVideo(true)
}
},

Expand Down