Techdebt/noid/node14 npm7

[marcoambrosini]

ref nextcloud/app-tutorial#319 (comment)

[PVince81]

@nickvergessen thanks for the suggestions. I already changed this in parallel, strange that Github doesn't say anything about this.

Now the errors are about actual code to adjust to satisfy eslint

[PVince81]

@marcoambrosini the jest stuff is fixed as you asked, do you want to take care of the reported eslint issues ?

[marcoambrosini]

@marcoambrosini the jest stuff is fixed as you asked, do you want to take care of the reported eslint issues ?

Thanks @PVince81, yes I will!

[nickvergessen]

do you want to take care of the reported eslint issues ?

We talked about it with skjnldsv yesterday and it might also be okay to add a temporary exception to the eslint as it's just a different prefered coding style

[skjnldsv]

We talked about it with skjnldsv yesterday and it might also be okay to add a temporary exception to the eslint as it's just a different prefered coding style

Yes, requires investigation though, this is an error, not a warning 😁

[marcoambrosini]

Yes, requires investigation though, this is an error, not a warning 😁

Should be a super easy fix, on it

[marcoambrosini]

Ok it should™ all be good now, reviews plz!

[nickvergessen]

Seems to break calls completely

• can't see my own video
• sharing the screen doesn't work anymore

 [Vue warn]: Error in callback for watcher "localMediaModel.attributes.localStream": "TypeError: adapter.browserDetails is undefined"

found in

---> <LocalVideo> at src/components/CallView/shared/LocalVideo.vue
       <Grid> at src/components/CallView/Grid/Grid.vue
         <CallView> at src/components/CallView/CallView.vue
           <MainView> at src/views/MainView.vue
             <AppContent>
               <Content>
                 <App> at src/App.vue
                   <Root> vue.runtime.esm.js:619

TypeError: adapter.browserDetails is undefined
    exports attachmediastream.js:41
    _setLocalStream LocalVideo.vue:261
    localStream LocalVideo.vue:203
    VueJS 5

[nickvergessen]

Tested with:

• Edge
• Safari
• Firefox
• Chromium

[nickvergessen]

#5817